Editorial: Add note about hard-coded overflow constrain #3162
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3162 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 22 22
Lines 10209 10209
Branches 1839 1839
=======================================
Hits 9894 9894
Misses 266 266
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justingrant
approved these changes
Oct 4, 2025
| 1. If _sign_ × (_d1_ - _isoDate2_.[[Day]]) > 0, return *true*. | ||
| 1. Return *false*. | ||
| </emu-alg> | ||
| <emu-note>This operation intentionally uses overflow ~constrain~ when regulating the year-month.</emu-note> |
There was a problem hiding this comment.
Is it worth explaining why we use ~constrain~ here?
There was a problem hiding this comment.
I'm not sure I can clearly explain why. It's just a choice we made for how the algorithm works. There are other choices that could have been made.
Do you want to try?
There was a problem hiding this comment.
I suspect that @ptomato may have more recent knowledge than I do about this.
ptomato
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intentional, but it looks like a bug when implementing, so it's worth calling out.